Grid Movement - Animation Issues

Krixus

1). So this is 3D grid battles, phase combat, mecanim animation system. I'm basically converting the ORK 2 grid movement event over to the ORK 3 schematic.

In ORK 2, I don't have any character controller, rigidbody, nav mesh agent etc on the combatant prefabs but the run animations all trigger properly etc.

In ORK 3, the "Default Movement Component" is a nav mesh agent, but this is only for field stuff. The actual combat prefab (conditional prefab), only has a transform and animator on it.

Issue: When using the "Change Position" node, the "Move Component" is set to "Transform" however it doesn't move along the X axis, instead it moves downward Y axis, it just keeps moving down and sometimes it finally ends up on the destination grid and other times it just loops forever. I have tried enabling "Y" in "Lock Movement" too, but doing that just cancels out the actual movement and makes it instantly appear on the tile. I believe there is some issue within "Change Position" node, perhaps some setting?

Setup:

Krixus

2). The second issue is once the combatant eventually makes it there, the run animation doesn't stop running and it doesn't transition back to the idle animation. I have also enabled "Auto Animation" already, but whatever I do, it just keeps running on the spot.

I don't have this issue with field animations, IE walking, running, sprinting then stopping via mouse click/nav mesh agent. But for grid movement on the grid, I just can't get the run animation to stop and transition back to idle.

Setup:

General settings first for combatants:

Individual/override settings specific to the test combatant:

"Animations" setup in Base/Control - for idle/run:

Animator Controller:

Krixus

3). I am trying to trigger an "Attack of Opportunity" like in DnD. I had this working in ORK 2 but I'm not sure where I've gone wrong when converting it over to ORK 3.

Rather than showing screenshots here, I've just emailed you over two schematics.

Animation_Schematic_4_Grid_Movement - is the schematic I use in my own project that I can't seem to trigger an attack via "Use Battle Action".

GridMove - is the schematic where I've tried to paste over the nodes again that I used in the first schematic, but this schematic is something you can drop into the ORK 2D Battle Grid project. I try to trigger the base "Attack" when a combatant moves out of range and I just can't seem to trigger it.

I'd appreciate it if you could show me where I've gone wrong. Even better though would be if you could make the adjustments in the schematics and email them back, but either way is fine I'd just like to figure out where I've gone wrong.

Krixus

@gamingislove Any chance you could take a look at this? I think this thread was missed.

gamingislove

1) Most likely due to using Transform and having Apply Gravity enabled. Moving by transform ignores physics, so the ground doesn't stop the object from moving down.
Even if NavMesh is used for field stuff in your project - as long as there is a baked NavMesh you can still use it for movement in battle.

2) For Mecanim it's recommended to use the Auto Move Speed Parameters of your Mecanim animation setup instead of auto animations. That way you can forward the movement speed of the combatant (from the object physically moving) to the animator controller and use a blend tree to change between idle and movement animations.
Auto animations is mainly for the legacy animation system (as it also was in ORK 2).

3) Sorry - I've taken a quick look, and this is far too complex to figure out quickly and on it's own (without a test project or at least more information on how this should operate). I've seen some things at first glance, e.g. during the attack of opportunity some check nodes will end the schematic if they fail, not sure if that is what you want; or the Change Selected Data Quantity node will not work the way you think, it's used to change quantity of inventory content in selected data, e.g. items.
This is a case for paid support if you're interested :)

Krixus

gamingislove

So, I'll focus on #3 for now and just split it up and try to make it simpler.

3a). For the attack of opportunity, I am trying to trigger the "Use Battle Action" in two scenarios. One is when the combatant/grid user is moving into range of an enemy combatant and the second is when they are moving out of range, so move by and move in.

My first issue is the "move in/moving into range". The issue is that "In Range" from the "Grid Move Out Of Range" node seems to trigger regardless and ignore the actual battle range of the attack/ability.

So, in the schematic, I've enabled "Move In Range" and even if I just move a single tile in any direction, "In Range" will trigger and trigger game over (used for testing). I also added an output to unity console log too.

It checks the use range "Attack", so here is the setup.

So yeah, based on that the "In Range" should only trigger when the combatant moves right up to the combatant, literally 1 tile away, yet it currently triggers even if you move just 1 tile up and you are like 6 tiles away.

I have this set up in a test project too, if you want me to send it over. It is based off the ORK 2D Grid project. The schematic is "Grid Move 1", just swap it out with the default schematic within move command.

3b). So, the other part of the problem is triggering the move by, IE when the combatant moves out of range. I have a much simpler schematic, I'm really hoping you can help me with this. Firstly, what node should I use then instead of "Change Selected Data Quantity" node?

This is what the ORK 2 event looks like, based on the ORK Framework 2 mission grid battles.

I'm trying to replicate that, I thought it would be straightforward, but I've been struggling for weeks to get this done lol. I'm trying to find the node to substitute "Change Found Objects". You mentioned it is not "Change Selected Data Quantity" node, so which node should I use in context of this schematic?

As noted above, I have a test project set up now that I can send over. The schematic that I have set up is called "Grid Move", not "Grid Move 1". "Grid Move" is defined in the grid movement by default.

3c). Similar to 3b but in the same schematic, "Grid Move", when I disable "Move In Range" in the "Grid Move Out Of Range" node, "In Range" does not trigger, it always fails and goes to "Out of Range". So yeah, never mind going to "Selected Data Count" or even the "Change Selected Data Quantity" node, which then leads to the "Use Battle Action" node, it always fails even when the range should be correct. It's based on "Attack" Use Range, which is just 1 tile, cell selection is next, so from what I understand it should be a success and trigger when the grid user of the grid movement schematic moves by an enemy combatant.

Or...is success and fail swapped? I read the tooltip and I thought "In Range" meant success?

Edit: God damn...so I think there's actually a bug with this "Grid Move Out Of Range" node! If I set "Use Range" to a battle template, aka the same battle template/target selection etc etc that my ability or base attack uses, then the Opportunity Attack triggers. Soon as I swap the "Use Range" back to either an ability or just base "Attack" it breaks and fails again.

3d). So, the "Grid Move Out Of Range" node's use range to battle template, will trigger the Opportunity Attack. However, there's more issues. If I am 1 tile away from the enemy combatant, so face to face and then I just move 1 tile away and the grid user combatant is killed by the Opportunity Attack, the prefab will still move to the destination cell after it gets killed. That's the first issue.

The second issue is I get this error below:

MissingReferenceException: The object of type 'GamingIsLove.Makinom.Components.UIColorChanger' has been destroyed but you are still trying to access it.
Your script should either check if it is null or you should not destroy the object.
UnityEngine.Object+MarshalledUnityObject.TryThrowEditorNullExceptionObject (UnityEngine.Object unityObj, System.String parameterName) (at <d35f3fd492a14898b9e7cb0372b7ba3d>:0)
UnityEngine.Bindings.ThrowHelper.ThrowNullReferenceException (System.Object obj) (at <d35f3fd492a14898b9e7cb0372b7ba3d>:0)
UnityEngine.Behaviour.get_isActiveAndEnabled () (at <d35f3fd492a14898b9e7cb0372b7ba3d>:0)
GamingIsLove.Makinom.Components.UIColorChanger.UpdateColors (UnityEngine.Color color, System.Boolean isFlash) (at <bc256f5028ce44f19d857b0a10374b72>:0)
GamingIsLove.Makinom.Components.HUDComponent.Clear () (at <bc256f5028ce44f19d857b0a10374b72>:0)
GamingIsLove.Makinom.Components.HUDComponent.DoClosed () (at <bc256f5028ce44f19d857b0a10374b72>:0)
GamingIsLove.Makinom.Components.HUDComponent.Closed () (at <bc256f5028ce44f19d857b0a10374b72>:0)
GamingIsLove.Makinom.UI.UIStateChange.Use (GamingIsLove.Makinom.BaseWaitForAnim waitForAnim, GamingIsLove.Makinom.Notify callback, System.Boolean wait) (at <bc256f5028ce44f19d857b0a10374b72>:0)
GamingIsLove.Makinom.Components.HUDComponent.DoClose () (at <bc256f5028ce44f19d857b0a10374b72>:0)
GamingIsLove.Makinom.Components.HUDComponent.Close () (at <bc256f5028ce44f19d857b0a10374b72>:0)
GamingIsLove.ORKFramework.UI.LatestTurnHUDInstance.UpdateLatestTurn (GamingIsLove.ORKFramework.Combatant combatant) (at <5ff43a3101e74ca4ae68fee2c8165b6a>:0)
GamingIsLove.ORKFramework.Battle.FireLatestTurn (GamingIsLove.ORKFramework.Combatant combatant) (at <5ff43a3101e74ca4ae68fee2c8165b6a>:0)
GamingIsLove.ORKFramework.PhaseBattleSystem.CombatantCanceled (GamingIsLove.ORKFramework.Combatant user, System.Boolean unsetLatestTurn) (at <5ff43a3101e74ca4ae68fee2c8165b6a>:0)
GamingIsLove.ORKFramework.PhaseBattleSystem.CombatantSelected (GamingIsLove.ORKFramework.Combatant combatant) (at <5ff43a3101e74ca4ae68fee2c8165b6a>:0)
GamingIsLove.ORKFramework.PhaseBattleSystem.Tick () (at <5ff43a3101e74ca4ae68fee2c8165b6a>:0)
GamingIsLove.ORKFramework.Battle.Tick () (at <5ff43a3101e74ca4ae68fee2c8165b6a>:0)
GamingIsLove.Makinom.Maki.FireTick () (at <22800e737de149848611b4b2136772ff>:0)
GamingIsLove.Makinom.MakinomHandler.Update () (at <22800e737de149848611b4b2136772ff>:0)

Sometimes, I'll also get this error, I believe it is different to the error above. Error 2:

MissingReferenceException: The object of type 'GamingIsLove.Makinom.Components.UIColorChanger' has been destroyed but you are still trying to access it.
Your script should either check if it is null or you should not destroy the object.
UnityEngine.Object+MarshalledUnityObject.TryThrowEditorNullExceptionObject (UnityEngine.Object unityObj, System.String parameterName) (at <d35f3fd492a14898b9e7cb0372b7ba3d>:0)
UnityEngine.Bindings.ThrowHelper.ThrowNullReferenceException (System.Object obj) (at <d35f3fd492a14898b9e7cb0372b7ba3d>:0)
UnityEngine.Behaviour.get_isActiveAndEnabled () (at <d35f3fd492a14898b9e7cb0372b7ba3d>:0)
GamingIsLove.Makinom.Components.UIColorChanger.UpdateColors (UnityEngine.Color color, System.Boolean isFlash) (at <bc256f5028ce44f19d857b0a10374b72>:0)
GamingIsLove.Makinom.Components.HUDComponent.Clear () (at <bc256f5028ce44f19d857b0a10374b72>:0)
GamingIsLove.Makinom.Components.HUDComponent.DoClosed () (at <bc256f5028ce44f19d857b0a10374b72>:0)
GamingIsLove.Makinom.Components.HUDComponent.Closed () (at <bc256f5028ce44f19d857b0a10374b72>:0)
GamingIsLove.Makinom.UI.UIStateChange.Use (GamingIsLove.Makinom.BaseWaitForAnim waitForAnim, GamingIsLove.Makinom.Notify callback, System.Boolean wait) (at <bc256f5028ce44f19d857b0a10374b72>:0)
GamingIsLove.Makinom.Components.HUDComponent.DoClose () (at <bc256f5028ce44f19d857b0a10374b72>:0)
GamingIsLove.Makinom.Components.HUDComponent.Close () (at <bc256f5028ce44f19d857b0a10374b72>:0)
GamingIsLove.ORKFramework.UI.LatestTurnHUDInstance.Close () (at <5ff43a3101e74ca4ae68fee2c8165b6a>:0)
GamingIsLove.Makinom.UI.HUDInstance.Tick () (at <22800e737de149848611b4b2136772ff>:0)
GamingIsLove.Makinom.UI.BaseUIHandler.Tick () (at <22800e737de149848611b4b2136772ff>:0)
GamingIsLove.Makinom.Maki.FireTick () (at <22800e737de149848611b4b2136772ff>:0)
GamingIsLove.Makinom.MakinomHandler.Update () (at <22800e737de149848611b4b2136772ff>:0)

I got the second error when I ran past two enemy combatants with the destination cell being 1 tile to the left of them, the enemy combatants where standing shoulder to shoulder in a line. The first error triggers when grid movement starts 1 tile away from an enemy then moving 1 tile away and getting killed. The second one starts when grid movement starts out of use range of enemy targets, but then I enter use range, (1 tile) and run past them in a line and get killed. So basically, I think it's triggering the "looping" part of the grid movement schematic where it checks for a continuing path since the grid user is not just moving 1 tile up but moving across multiple tiles. In my own schematic I basically have to call the "opportunity attack" part of the schematic twice, one when just moving 1 tile and a second time when moving multiple tiles to check both scenarios of if the grid movement user is moving away from an enemy combatant.

Also, both of these errors only trigger after runtime is finished. I'll exit the game and then in the Unity editor, I'll see the errors after I exit out from runtime testing.

Edit: So, it seems my "Check Variable" was failing and the "Clear Grid Path" node was not triggering and I guess that would solve the issue of the dead combatant still moving to the tile after it was killed by the opportunity attack? However, I still don't know what the error is for.

Setup:

This is what my own schematic for the opportunity attack looks like, I guess it's slightly different to the test project's one (which I haven't sent yet), in that it doesn't have the "Clear Grid Path" node. The "test project" schematic is shown in 3a, just with the nodes connected.

3e). I kinda got "move in" opportunity attacks to work by changing the "Grid Move Out of Range" node to use a battle range template as the use range (as explained in the issues above), however I still get errors after I exit runtime.

It's odd though because it only happens in one case. So after the grid user moves right up to the combatant (1 tile away) and the opportunity attack triggers, if the combatant dies then, then you'll get the error after you exit runtime, similar to above.

However, if rather than ending the cell path right next to the enemy combatant, if I end the path to the side of the enemy combatant, aka 1 tile away but the cell path still passes by the enemy combatant, then the error doesn't appear. I guess is it because "move by" triggers rather than "move in"? Or shouldn't both trigger in this case?

Error:

MissingReferenceException: The object of type 'GamingIsLove.Makinom.Components.UIColorChanger' has been destroyed but you are still trying to access it.
Your script should either check if it is null or you should not destroy the object.
UnityEngine.Object+MarshalledUnityObject.TryThrowEditorNullExceptionObject (UnityEngine.Object unityObj, System.String parameterName) (at <d35f3fd492a14898b9e7cb0372b7ba3d>:0)
UnityEngine.Bindings.ThrowHelper.ThrowNullReferenceException (System.Object obj) (at <d35f3fd492a14898b9e7cb0372b7ba3d>:0)
UnityEngine.Behaviour.get_isActiveAndEnabled () (at <d35f3fd492a14898b9e7cb0372b7ba3d>:0)
GamingIsLove.Makinom.Components.UIColorChanger.UpdateColors (UnityEngine.Color color, System.Boolean isFlash) (at <bc256f5028ce44f19d857b0a10374b72>:0)
GamingIsLove.Makinom.Components.HUDComponent.Clear () (at <bc256f5028ce44f19d857b0a10374b72>:0)
GamingIsLove.Makinom.Components.HUDComponent.DoClosed () (at <bc256f5028ce44f19d857b0a10374b72>:0)
GamingIsLove.Makinom.Components.HUDComponent.Closed () (at <bc256f5028ce44f19d857b0a10374b72>:0)
GamingIsLove.Makinom.UI.UIStateChange.Use (GamingIsLove.Makinom.BaseWaitForAnim waitForAnim, GamingIsLove.Makinom.Notify callback, System.Boolean wait) (at <bc256f5028ce44f19d857b0a10374b72>:0)
GamingIsLove.Makinom.Components.HUDComponent.DoClose () (at <bc256f5028ce44f19d857b0a10374b72>:0)
GamingIsLove.Makinom.Components.HUDComponent.Close () (at <bc256f5028ce44f19d857b0a10374b72>:0)
GamingIsLove.ORKFramework.UI.LatestTurnHUDInstance.Close () (at <5ff43a3101e74ca4ae68fee2c8165b6a>:0)
GamingIsLove.Makinom.UI.HUDInstance.Tick () (at <22800e737de149848611b4b2136772ff>:0)
GamingIsLove.Makinom.UI.BaseUIHandler.Tick () (at <22800e737de149848611b4b2136772ff>:0)
GamingIsLove.Makinom.Maki.FireTick () (at <22800e737de149848611b4b2136772ff>:0)
GamingIsLove.Makinom.MakinomHandler.Update () (at <22800e737de149848611b4b2136772ff>:0)

Setup:

For the "move in" opportunity attack, I have two separate schematics. I call the first one before the grid movement and the second schematic, after the grid movement, basically similar to how the ORK 2 mission grid battles is setup.

Before Main Grid Movement Schematic:

After Main Grid Movement Schematic:

Compared to ORK 2 events:

I double checked to see if the "errors" would happen due to normal deaths. What I mean by that is aka your player combatant gets killed by the enemy during their turn. But no, it seems the error only happens when a combatant gets killed via moveIn, normal kills not triggered by "Use Battle Action" don't result in the error, so it does seem somehow tied to my setup for these moveIn/moveBy actions.

3f). I have this really weird issue where I use the same schematic in two different projects, but it works in one project and not the other.

This is related to 3e. If you refer to the "After Main Grid Movement Schematic", so this is the third schematic that I define, that should trigger the moveIn opportunity attack. In my testing project it triggers when I move in and stop 1 tile from an enemy combatant, the opportunity attack triggers. But in my main project, when I try to use this schematics, the MoveIn Opportunity attack doesn't trigger.

I've used literally the exact same schematics, in both projects and set them up exactly the same way.

They all use the exact same settings above ^ for all three schematics related to grid movement in both project.

Issue: I've found out that for some reason, in my main project, that "Selected Data Count" fails in my main project. IE referring to "After Main Grid Movement Schematic", I check for "move_in" via a "Select Combatant Objects" node in "Before Main Grid Movement Schematic". I store it there, within the first schematic "Select Data Count" succeeds and goes to "Grid Move Out Of Range" node. However, when it checks it again, in the last schematic, it fails.

I don't know why it works in one project and why it fails in another project, are there extra settings that I've enabled somewhere that I have forgotten? The selected data is local, like some setting where local selected data is shared amongst schematics or something?

This extra node in the red box, in my test project I don't need to add this node again, it's only used once in the first schematic, before the main grid movement schematic. However in my main build, the only way I can get "Use Battle Action" to trigger is to use the "Select Combatant Objects" node again, otherwise "Selected Data Count" will fail. And that is the crux of my issue, where there is a difference between the two projects. I've also made sure to update my main project build to the latest version of ORK 3, I've tried to rule out all the differences, but still can't solve it. It's doing my head in lol.

gamingislove

3a) Did a quick test with the Grid Move Out Of Range node and it definitely works correctly. Tested with Attack use range selection.
Not sure if your setup is correct, though - first of all, instead of using selected data to find combatants, you could also just use the Enemies (Battle) actor to get all enemies of the machine object that are in battle. Maybe there is an issue with your selected data setup and you e.g. also have the user in there, which possibly is always within range.
The actual out of range node in your setup uses Next cell selection, i.e. it checks the next node of the path. If this is used at the start of the grid move schematics, you should use All to check the whole path if it moves into/out of range at any point. If it's used as part of the cell move loop (i.e. where the Next cell selection should be used) you should use it before getting and removing the next node.

3b) I think we already talked about this either in this thread or a different one. If you want to change selected data (beside clearing it alltogether), you need to use the Select ... node matching the things you want to e.g. remove or set, like the Select Combatant node if you want to add, remove or set combatants.

3c) See 3a - definitely works correctly.

3d+e) Will add safeguards around that, though if that's only happening when stopping play it's something that can be ignored (basically Unity trying to access something that it already destroyed).

3f) Well, you left out the crucial part - the setup for this Select Combatant Objects node :)
If this is the one place where the selected data is changed, that's where the difference lies - however it's set up, in one project it'll find combatants and it doesn't in others.

Krixus

gamingislove

3f). So, the full set up is three separate schematics. I have this exact same setup, with the exact same schematics in two different projects, but for whatever reason, the moveIn opportunity attack triggers in the test build, but in my main build, even with everything the same, the moveIn opportunity attack doesn't trigger.

The reason it doesn't trigger is because it seems "Selected Data Count" fails.

I have used "Select Combatant Objects" node in another place, which is the first schematic. That's what my issue is. I don't know why it works in the test project but it doesn't in my main build, despite having the exact same schematics. So I can only conclude that there's extra settings that I've touched somewhere, which is what I'm hoping you could help me with.

Setup:

I'll reiterate. In both projects, I have these exact three schematics, set up in the same way, same order, I've double checked that none of them have extra conditions (defined in each battle animation option) or something like that which could be interfering and being that "gotcha" moment. That's not the case.

I won't bother posting the main "Grid Movement" schematic, as previously you've said that's too complex. I'll focus on the first and third schematic as that is directly related to triggering the "moveIn" opportunity attack. Just to clarify though, the main "Grid Movement" schematic is still exactly the same in both projects too.

1st schematic:

So, I already use "Select Combatant Objects" node here, in the first schematic. In both projects, the first schematic works, "Selected Data Count" results in success. The setup for the "Select Combatant Objects" node in both projects is this.

I am searching for any enemy combatants of the user, then store them into "move_in". Then "Selected Data Count" checks if it is greater than 0 and it succeeds.

3rd schematic:

This is where the difference lies. In my test project, "Selected Data Count" succeeds, the information from the first schematic's "Select Combatant Objects" node, passes onto this schematic (all local) and so "Use Battle Action" can trigger.

The issue is in my main build, even with everything literally the same, for whatever reason in the 3rd schematic, "Selected Data Count" fails, as it seems to not have that information? And so "Use Battle Action" is never reached.

This is what is really doing my head in and what I need an answer on. Are there extra options related to like sharing and passing on local schematics or something? Tucked away in other editor related to grid movement that I have forgotten to setup?

Because I don't understand why these exact same schematics work in one project and not the other, there's obviously something that's different and it's not the "Selected Combatant Objects" node. Because I've already used it in the first schematic and it works in the test build, but not in the main build so my suspicion is there's other settings I've forgotten. I'd really appreciate it if you could help me on this.

As for your response:

"If this is the one place where the selected data is changed, that's where the difference lies - however it's set up, in one project it'll find combatants and it doesn't in others."

I'm not really sure what you mean. If I use the exact same schematics and exact same setup of the schematics for battle grid movement, the result should be the same in both projects, they are both the same versions of ORK 3 too. The last image where I put the red box around "Select Combatant Objects", I should haven't to use that node again in my main project as I've already used it in the first schematic and I only have to use it once in the test build for it to work.

For it to not work in my main build, I can only assume there's other settings outside of the schematics? I shouldn't have to add "Select Combatant Objects" again in the 3rd schematic in the main build, in order for "Selected Data Count" to result in success if I don't have to do it in the test build because it already results in success from using it in the first schematic. Please help lol.

So yeah, the solution is not to use "Select Combatant Objects" node again in the third schematic. I didn't have to use it in the test build so I shouldn't have to use it in the main build, that makes no sense. Are there other settings somewhere else, related to schematics sharing information, like local variable/selected data etc? That's the only thing I can think of that would cause a difference in two projects that otherwise use the exact same schematics and setup for grid movement.

EDIT: I did more testing. If I use the exact same setup and swap all the "move_in" selected data references to global, rather than local, then it will work in my main project. But I still don't understand why the "local" selected data works perfectly fine in my test project. If the setup and schematics are literally the same, but local selected data works in one project and not the other, than the issue must be related to some editor setting right? Please help me finally solve this issue. The solution can't just be "swap it all to global" if it works fine already as "local" selected data in my test project and both projects are the same versions of ORK 3. I've scoured the editor, trying to find some sort of related setting to grid movement and selected data sharing.

Krixus

3f). So, I have an update on this, for over 8 days ago. I've found one of the culprits, I knew I wasn't losing my mind, lel.

First Issue: I now know one of the main differences between my main build and the test project that is triggering the "moveIn", opportunity attack. My test build has "grid move" as a default shortcut assignment. As soon as it is defined, whether you use the grid move command via the battle menu, or the grid move via the shortcut bar, the "moveIn" opportunity attacks suddenly "trigger".

As soon as you delete it, they no longer trigger again. I have this all replicated in the 2D Grid Battle project, I can send it over.

Second Issue: I say they "trigger" as in the "moveIn" opportunity attack kinda works. All my abilities/attacks have an ability variable and the animation schematic checks for it. Specifically, during the "moveIn" checks though, when this skill is used as the battle action, via "Use Battle Action", the variable fork node check will always fail. If the exact same attack is used again "normally", as in during the enemy's phase rather than via "Use Battle Action", then the variable fork will work correctly.

Again, I also have this set up in the 2D Grid Battle project. In my project, what's currently happening is because of this fail at the variable fork, none of the actual animations trigger or anything as the variable fork check is very early on in the schematic.

Third Issue: Lastly, the most perplexing thing about this is in my test project, all of this more or less works, the variable fork check works too for some reason.

I say "works" as very tentative, because there are obviously issues going on. I'm still looking into this, although I do hope you respond to this soon. It obviously runs a lot deeper this issue and other stuff might not be working that I haven't noticed.

So there has to be something else that is different that's "making it work" somehow. It's very frustrating as because it's a test build project, I may not end up using everything I test, but I can't easily determine what's triggering/making it work, as I've gone through all the "obvious" options.

This is what I was talking about in my above post, about "some other option tucked away". AKA, it seems it is the grid move that you can define in shortcut settings that for whatever reason triggers the checks, makes it so that the "Select Combatant Objects" data set as local, passes onto the last schematic (three in total). But for some reason as soon as you delete this grid move in shortcut settings, the local data no longer passes, so the schematic doesn't trigger.

I don't know what other setting I have enabled in my test project that somehow makes the ability variables, defined in abilities to succeed in the variable fork check, I guess that's what I'd be looking into next.

I feel like these are all separate issues on their own, rather than the result of not just enabling some setting. So even if it "somehow" works, in my test project, these issues should still be rectified. AKA if you were trying to create "moveIn" opportunity attacks and you only used the battle menu to access the grid move command, you might not ever actually get it to work since you don't use a shortcut bar and have "grid move" defined there as well and the two of them don't really have an obvious connection with each other.

GeneralK

Hey @Krixus looking at your screenshot of the Select Combatant Objects node you do not have Store Combatants checked. That means it is storing the reference to the Unity Game object to selected data rather than the ORK Combatant reference.

I do not know which nodes that affects since the game object naturally has the Combatant component on it, however any time I am doing something with a combatant I would use the Select Combatant node instead of Select Combatant Objects node because for something like Use Battle Action or Change Status you want to reference the combatant, not the game object.

Not sure how much this will help but it's a 1 node swap out to try. Wonder if that is something to do with the Grid Move as well that one way is passing the actual game object so selected data count succeeds, and the other way is only passing the combatant reference that is using the action and not the game object itself so it doesn't store it?

Krixus

GeneralK

Thanks for responding, I'll try that out. I do actually eventually store the combatants though in the "Grid Move Out Of Range" node, but I probably didn't show a picture of that.

It's odd to say the least, I feel like it's an editor issue now rather than just a "complicated setup question" though.

@gamingislove I'd really appreciate if you could look into this, especially now that I have the issue replicated in a test project that I can send over, rather than just my rambling lol.

gamingislove

There is no difference between firing something via battle menu, control map or shortcut HUD - all use the same functionality to actually perform the action, and that's where the local selected data is shared.
The Use Battle Action, when used as a Sub Action, can also share selected data based on your setup, so that's also something that can impact it if you change the same data key in the action's schematics.

As @GeneralK pointed out, you're storing the game objects of the combatants - generally that's not an issue, since all nodes using combatants will get the combatant from the game object. However, if the game object is already destroyed (e.g. combatant died and was destroyed) you can no longer get it that way, while storing the combatants would still have it available.

Krixus

gamingislove

Even if I enable "Store Combatants" in the "Select Combatant Objects" node that I use for move in/move by, when I move in, the variable fork in the attack animation schematic always fails for some reason.

So, I still can't get this to work. Can I just please send over the test project because I've already set this all up and replicated it.

I've posted all the images of my setup too so at this point all I can really do is send the test project so you can see the issue for yourself.

In the interest of time, I'll post additional images here of the test project setup.

The three schematics I use for the grid movement, that I defined as the animations for grid movement in the battle grid settings, are as follows, in that specific order.

https://postimg.cc/fVVk9vc5

The crux of this issue revolves around "move_in/moveIn". When attack is used by "Use Battle Action", the schematic has a variable fork that checks for an ability variable and it always specifically fails when it is triggered via move_in/moveIn, it succeeds when it is used normally as an attack, IE during the enemy phase itself.

I'm not changing the ability variable at all. I literally just check it. I only define the ability variable in the editor, then I check it in the schematic, that's all I do. But it always fails when triggered this way.

I'm not sure if your response applies to all three points that I listed or if you are just responding to one of my points, but I tried it anyway and no luck, variable fork still fails.

In the event you can see that I now "Store Combatants" however I don't really see how that helps solve my issue which is centered around the variable fork in the attack schematic failing, the variable fork checks for the ability variable and it always fails when it is used this way.

It's very easy to trigger this issue in the test project. You just start a new battle, move one character down a few tiles, as there's an enemy combatant at the bottom of the map that will move forward. On the next turn, move right up to a tile that is next to the enemy combatant, you'll see the Unity output console, "log" type, it will output what I've linked to the "Failed" connection on the variable fork.

Can you please just take a look at why it is failing? Because at this point I've exhausted everything, I still can't get it all working correctly. The schematic works just fine when it is used normally as an attack, the variable fork always succeeds, but it always fails when used via Move In as Use Battle Action. Please help me identify what is causing this issue, please.

https://postimg.cc/G9dT9GHD
https://postimg.cc/rRFLC0cR
https://postimg.cc/tnCHtZyk
https://postimg.cc/CnLVHBYJ
https://postimg.cc/WqbP6Fjn

GeneralK

@Krixus man that postimg.cc has redirects and popups and doesn't like ad blockers heh.

Anyways I did a test this morning and it seems to work fine for me. I did not add variables yet for on hit. Maybe your missing piece is Select Selected Data node, it sure sounds like a selected data issue.

I did it this way because my battles have like 50 combatants so I didn't want to store all enemies at once, even though I am storing them every cell now it's only for the adjacent cells and my move range is small. I also use a separate enemy grid move and player grid move schematic.

Not saying your use case should be set up this way, just trying to clarify the selected data use if that might help identify what's going wrong in yours.

Make a Battle Range Template that does not have the Origin cell selected because otherwise you are storing that combatant too and even if you have isEnemy checks happening places, meh just to rule it out. I also used only Occupied checked so not storing empty cells and blocked cells.
I used Select Grid Cells (store combatants checked, Machine Object origin is passed from the Grid Move schem) but you could Select the combatants with other nodes
Selected data count for obvious reason don't run stuff if nothing there
Select Selected Data (with Remove checked) so this is getting 1 combatant stored by the Select Grid Cells node, Removing it from cell, and storing it to selectedCombatant selected data. All locals.
Check Status on selectedCombatant to see if the combatant can do the AOO (in my case is the Status Effect there from the equipment that grants AOO)
Use Battle Action Sub Action with selectedCombatant
Loop back to Select Selected Data after Use Battle Action or Failed Check Status. These loops are safe because once Select Selected Data can no longer find anything in the Source selected data, it will go Failed. Since we remove 1 each time it will eventually go Failed and not infinite loop.

https://imgur.com/a/CpM1U2T

I was also able to get it to work with Grid Move Out of Range set to Attack (checking the base attack range)
Again note I did not add variables yet
Same set up on selected data and it worked.

https://imgur.com/a/Y9PBCMu

And edit again lol.
For the MoveIn I checked Share Selected Data on the Start Machine node in the grid move schem. cell is the selected data name of the next cell. So then I changed the MoveIn schem Select Grid Cells node to get the ring around cell instead of Machine Object, and changed the selected data to cellAll so they don't conflict.

So now everything works (except hit/miss variable I haven't added yet still). Moving from beyond melee range in to range triggers, moving from melee range to out of melee range triggers, and also zone of control from cell to cell in melee range triggers.

https://imgur.com/a/GewzOzk

gamingislove

Thanks @GeneralK for helping out :)

@Krixus If what GeneralK said didn't help I'll take a look at your test project.

Krixus

gamingislove

I've sent the project over, I'd really appreciate it if you could just take a look, because I have my issue all setup already and replicated.

Earlier today, I thought I got close to finding out the mystery issue. I had another case where certain defined battle "animation" schematics were not "triggering" on the enemy combatants specifically, and I thought maybe that was the reason.

This specific case above ^, was basically I had an ability that has three separate battle animation schematics defined on it. The first schematic sets a variable, the second schematic handles the animation, the third schematic resets the variable. For whatever reason, the first schematic did not trigger when the enemy combatant used it, but it did for the player.

I found out the reason for this is because I didn't define a "base attack" in combatant general settings, well I defined it, but it was set to none. The enemy combatant then had that same "base attack" defined as an ability instead, rather than overriding the base attack. The combatant didn't have any battle AI so it was somehow using that ability I defined but not all the schematics were triggering.

After I went back to the combatant general settings and actually defined that same ability as the "base attack", so that it covered all combatants, then the first schematic was triggering properly on the enemy combatants.

@GeneralK I really appreciate you taking the time to help out, there's still just something within my editor settings that's preventing my schematic from working. Perhaps some setup error on my behalf.

This above example is what I mean, I feel like it's something like that within my editor settings that's causing the issue rather than the schematic itself.

@gamingislove I'd really appreciate it if you can just take a look at the test project and tell me what's wrong with it and what is causing the ability variable fork in the schematic to specifically fail via move in/use battle action but work fine when used as a normal ability. It's been 2 months now lol and I just can't solve this issue completely.

The instructions to replicate are in the post above, marked 7 days ago.

gamingislove

I've found the issue why the attack isn't working when used as part of the move, and it's an easy fix: Disable Share Selected Data in the Use Battle Action node.

The reason is pretty simple - when sharing the data with the attack (i.e. also the attack's schematics), it'll already have the local selected data's key action set to whatever it is used in (e.g. in this case, the move action). So, the variable checks operate on the wrong content. Disabling the setting will have the sub-action create it's own selected data with the correct action set in the key (i.e. the ability with the variables).

Is there any other issue that needs checking in this test project?

Krixus

gamingislove

1). Thanks, so disabling "Share Selected Data" in the last schematic, "Perform_MoveIn" does work however the thing is, I actually have "Share Selected Data" enabled in my own test project and the "Variable Fork" in the attack schematic is not actually failing, even with "Share Selected Data" enabled, everything is playing out correctly.

Because if the issue was just disabling "Share Selected Data", then that would have been something I picked up earlier since I was using literally the same schematics that were working in my own test build in both the project I sent over to you and my "main project".

If the schematics setup worked in my test project, with "Share Selected Data", then technically speaking it should have worked in the other projects too, the grid range checks were also setup correctly too, after I transferred them over.

Culprit: So, I've found out why the variable fork doesn't fail and thus why the moveIn AOO attack works in my test build with "Share Selected Data" enabled in the "Use Battle Action".

The "Use Battle Action", uses the base "Attack" as the action type. In my editor, I've defined the base attack in the general settings of combatants as "Sword Attack".

The enemy combatant that I am testing against to trigger the moveIn AOO attack, also has "Sword Attack" defined individually on it, in Attacks & Abilities as an ability. The reason I've done this is in my battle AI, I specifically select abilities to trigger rather than just fall back to base attacks.

As soon as I delete "Sword Attack" from Attacks & Abilities, the variable fork will fail with "Share Selected Data" enabled. As soon as it's defined again though, the variable fork will succeed even with "Share Selected Data" enabled.

So yeah, it turns out this is the difference in the projects, it was something else in the editor interfering with the schematics. Do you know why this is the case? And what should I do in this case? I've spent months on this lol, so I really want to get all the way to the bottom of this. Disabling "Share Selected Data" works yes, but I've also found the reason why it still works even with it enabled, is it a bug or setup error? Should there be guardrails?

Setup:

Variable setup on the ability.

General settings, combatants, base attack.

Combatant itself, defining the same "Ability" defined as "Base Attack" as an ability.

Perform_MoveIn schematic setup, with "Share Selected Data" enabled and the variable fork (in the separate attack schematic) not failing.

Krixus

2). There also is something else I'd like you to take a look at. This was set up in the previous project I sent over however I made a few changes, so I have sent you a new link via email.

My next issue is that "moveBy AOO" (triggered via Use Battle Action when moving out of use range, via "Grid Move Out of Range") attacks are also failing at the "variable fork" check in their own animation schematic. So basically, it's the same issue as "moveIn". The "moveBy AOO", uses the same ability via the "Use Battle Action", so in the battle animation schematic of the ability when it checks for the ability variable via the "Variable Fork" node, it also fails.

Now to clarify, I know this can be resolved by disabling "Share Selected Data", however the really odd thing is if I delete the "Grid Move" command that I have defined via "Default Shortcut Assignments" in "Shortcut Settings", then the "moveBy AOO" attack will correctly work, it will not fail at the "Variable Fork" node and I can actually keep "Share Selected Data" enabled too.

Just like 1) above, I really want to know why I don't have to disable "Share Selected Data" in my own test build because the moveIn/moveBy AOO attacks all work fine in that test build for whatever reason and I'd like to actually find the cause. If it didn't work already in my test build, then I would be fine with just disabling "Share Selected Data" as the solution.

I also know you mentioned this before when you said:

"There is no difference between firing something via battle menu, control map or shortcut HUD - all use the same functionality to actually perform the action, and that's where the local selected data is shared."

However, I have this replicated in the test project I sent over to you now.

There are two cases, "MoveIn" and also "MoveBy".

Basically, if you don't have "Grid Move Command" defined in "Default Shortcut Assignments", in the schematic "Animation_Schematic_5_Perform_MoveIn 1 [Use This]", the "Selected Data Count" node will fail.

If you however define "Grid Move Command" in "Default Shortcut Assignments", then when you trigger it again, the "Selected Data count" node in "Animation_Schematic_5_Perform_MoveIn 1 [Use This]" will actually succeed.

The second case is "MoveBy", which is the issue that I am facing in my own project that I have replicated in the test project I sent over. If you delete "Grid Move Command" in "Default Shortcut Assignments" the moveBy attack will completely work, so it will not fail at the "Variable Fork", nor do you need to disable "Share Selected Data". However, as soon as you define it, then in the attack animation schematic for the moveBy attack, it will fail at the variable fork.

Again, I know that if you disable "Share Selected Data" it will work, but what I'm asking here is why does the "Grid Move Command" in the "Default Shortcut Assignments" impact moveIn/moveBy.

And touching back on the point above 1), this is what I mean by there is something else in my own test project that is allowing the attack schematic to fully playout "variable fork succeed" without having to disable "Share Selected Data", I'd like to actually find out the cause of that.

I've attached images via the email thread because the image hosting website I normally use is currently having issues. In both cases, all you really need to do is move 1 character all the way down south on the combat map, there is a combatant there. Move in to the tile next to it, to trigger MoveIn issues then move away from it (1 tile away) to trigger the MoveBy issues.