twill14

I'm putting this here because I don't know if it's a bug on ORK's end, or something I've not done that I needed to do after updating (to 3.20). But, ever since updating, I've been getting the error:Assets\Gaming Is Love\Makinom 2\Plugins\Scripts\UnityInputActionInputIDKeySetting.cs(89,25): error CS0115: 'UnityInputActionInputIDKeySetting.InputMaxHoldTime': no suitable method found to override

For InputMaxHaxHoldTime (above), InputHoldTime, InputTimeout, and Handling.

My guess is that it has something to do with the code from the Unity Input Actions plugin?

gamingislove

Needed an update to be compatible with Makinom 2.19 - both Unity Input Action and Rewired input key extensions have been updated to be compatible and make use of the new features (e.g. trigger count).

I'll also provide input search sources for the new ORK input rebinding soon.
Edit: Ok, that might take a bit longer ...

twill14

no worries! Thanks for taking a look!

twill14

oh, while I'm looking at it, there was also one reoccurring bug I kept running into that my be related:

Type 'Vector2Composite' registered as '2DVector' (mentioned in '2DVector(whichSideWins=1)') has no public field called 'whichSideWins'
UnityEngine.InputSystem.InputAction:Enable ()
GamingIsLove.Makinom.UnityInputActionInputIDKeySetting:Tick (GamingIsLove.Makinom.InputIDKey,int) (at Assets/Gaming Is Love/Makinom 2/Plugins/Scripts/UnityInputActionInputIDKeySetting.cs:76)
GamingIsLove.Makinom.InputIDKey:Tick (int)
GamingIsLove.Makinom.InputKey:Tick ()
GamingIsLove.Makinom.InputKeysSettings:Tick ()
GamingIsLove.Makinom.Maki:FireTick ()
GamingIsLove.Makinom.MakinomHandler:Update ()

gamingislove

That sounds more like an issue in Unity's input system, or the setup of that action.
ORK/Makinom just call/use functionality of the actions, and the issue is caused by the input action itself.

twill14

Ah, I see. I'll check again, then. Thanks!

Socrates422

I've been using the asset Rewired with the previous versions of ORK. I updated to ORK 3.20 and got the error above regarding the four functions in the RewiredInputKey script. (InputTimeout, InputHoldTime, InputMaxHoldTime, and InputHandling).

I just enclosed those functions in comments like this

/*
public override float InputTimeout
{
get { return this.inputTimeout; }
}

public override float InputHoldTime
{
get { return this.inputHoldTime; }
}

public override float InputMaxHoldTime
{
get { return this.inputMaxHoldTime; }
}

public override InputHandling Handling
{
get { return this.handling; }
}
*/


The Rewired keybinding appears to be working correcty with the ORK 3.20 update now. I assumed those functions were changed or no longer used by ORK 3.20 and that was the reason for the error?

(I did this before seeing the posts above.)

Acissathar

@Socrates422 The Rewired Input Key asset was also updated for this: https://makinom.com/guide/extensions/scripts/rewired-input-key Should just be able to overwrite the existing one (worked in my project)

Socrates422

@Acissathar That is a better solution. I imported it and it works fine. It looks like those functions were removed, but there may have been other changes in the file that I didn't notice. Thank you.

gamingislove

Input keys have been a bit restructured and added new features, so use the updated extension scripts to make full use of them :)